linux-kernel - Re: [PATCH] MIPS: remove checks for CONFIG_SGI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1400767088.16407.14.camel@x220>
Date:	Thu, 22 May 2014 15:58:08 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Ralf Baechle <ralf@...ux-mips.org>
Cc:	linux-mips@...ux-mips.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS: remove checks for CONFIG_SGI_IP35

On Thu, 2014-05-22 at 15:12 +0200, Ralf Baechle wrote:
> On Tue, May 20, 2014 at 01:21:49PM +0200, Paul Bolle wrote:
> 
> > Ever since (shortly before) v2.4.0 there have been checks for
> > CONFIG_SGI_IP35. But a Kconfig symbol SGI_IP35 was never added to the
> > tree. Remove these checks.
> > 
> > Signed-off-by: Paul Bolle <pebolle@...cali.nl>
> > ---
> > Untested.
> > 
> > For some reason CONFIG_SGI_IP35 was heavily used in arch/ia64 too.
> > Anyhow, IA64 has dropped that macro years ago.
> 
> The #ifdefs exist because these headers are originally from IRIX and the
> equivalent IRIX definitions were converted to Linux-style.  For the
> IA64 version keeping those ifdefs around obviously made no sense since -
> since IP35 (Origin 300/3000 series) is MIPS-based, so it was dropped
> again.

Nice to know. Thanks.

> There is some out-of-tree support for IP35 so I'd like to drop this
> patch.

Thanks for handling this (and the similar) patches so quickly. I
disagree with your decision here. But there are many, many issues like
this still left in the tree. So there's no point in making noise about
just this one Kconfig macro.

By the way, could you perhaps look at CONFIG_SYS_HAS_CPU_RM9000? It
seems the Kconfig entry for SYS_HAS_CPU_RM9000 is simply missing. But
the CPU support code is rather complicated and I stopped trying to
understand it after staring at it for way too long.

Thanks again,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/