linux-kernel - Re: [PATCH 0/3] staging/skein: more cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140522170441.GW8664@titan.lakedaemon.net>
Date:	Thu, 22 May 2014 13:04:41 -0400
From:	Jason Cooper <jason@...edaemon.net>
To:	Jake Edge <jake@....net>
Cc:	Anton Saraev <antonysaraev@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	Joe Perches <joe@...ches.com>,
	Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [PATCH 0/3] staging/skein: more cleanup

On Thu, May 22, 2014 at 10:52:06AM -0600, Jake Edge wrote:
> On Wed, 21 May 2014 01:52:17 +0400 Anton Saraev wrote:
> > On Tue, May 20, 2014 at 10:24:11AM -0600, Jake Edge wrote:
> > > On Tue, 20 May 2014 10:47:57 -0400 Jason Cooper wrote:
> > >
> > > but some kind of tests are needed to ensure nothing breaks before
> > > digging into that ...
> > 
> > I have some test: slightly modified version of tests from
> > https://github.com/wernerd/Skein3Fish. It works as debugfs entry
> > and require some modification needed for module support
> > ("public" function must be extern). As I can understand Jason
> > has his own tests. That would be logical to share them but
> > I don't know where.
> 
> well, it seems to me that we want tests that eventually can be added
> into the crypto test framework once skein moves out of staging and into
> crypto ... Jason's objdiff seems like it would be used as another
> development tool ...
> 
> so do you have your tests anywhere that we can look at them?  or,
> failing that, maybe you can just email me a copy off-list or something?

https://github.com/wernerd/Skein3Fish/tree/master/c/test

This is the same repo I pulled the original source files from.  I looked
at integrating into the crypto test framework a few months back and
realized the crypto API needed to be modified to handle tweakable block
ciphers.

> do you have patches pending for skein?  i might get a chance to hack on
> this some over the weekend, and we may as well try to avoid duplicating
> each other's efforts ...

I do not, I'm unsure if Anton has anything pending capable of
upstreaming.

thx,

Jason.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/