linux-kernel - Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140522205606.GF27329@lukather>
Date:	Thu, 22 May 2014 22:56:06 +0200
From:	Maxime Ripard <maxime.ripard@...e-electrons.com>
To:	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
Cc:	wim@...ana.be, Guenter Roeck <linux@...ck-us.net>,
	Arnd Bergmann <arnd@...db.de>, dbaryshkov@...il.com,
	dwmw2@...radead.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, linux-watchdog@...r.kernel.org,
	linux-sunxi@...glegroups.com
Subject: Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog
 driver

On Thu, May 22, 2014 at 09:39:43PM +0100, One Thousand Gnomes wrote:
> On Thu, 22 May 2014 22:34:44 +0200
> Maxime Ripard <maxime.ripard@...e-electrons.com> wrote:
> 
> > On Mon, May 19, 2014 at 05:04:22PM +0200, Maxime Ripard wrote:
> > > On Thu, May 15, 2014 at 11:11:23AM +0200, Maxime Ripard wrote:
> > > > On Wed, May 07, 2014 at 02:33:18PM -0700, Guenter Roeck wrote:
> > > > > On Tue, May 06, 2014 at 09:44:19PM -0500, Maxime Ripard wrote:
> > > > > > Most of the watchdog code is duplicated between the machine restart code and
> > > > > > the watchdog driver. Add the restart hook to the watchdog driver, to be able to
> > > > > > remove it from the machine code eventually.
> > > > > > 
> > > > > > Signed-off-by: Maxime Ripard <maxime.ripard@...e-electrons.com>
> > > > > > Acked-by: Arnd Bergmann <arnd@...db.de>
> > > > > 
> > > > > Reviewed-by: Guenter Roeck <linux@...ck-us.net>
> > > > 
> > > > Wim, do you have any comment on this one?
> > > 
> > > Ping?
> > > 
> > > It would be really great to see this in 3.16, and we get quite close
> > > to the end of ARM's merge window.
> > 
> > Ping?
> > 
> > Guenter, since you seem to be the only responsive, may I suggest that
> > you start merging patches and do a pull request to either Wim or Linus
> > directly during the merge window?
> 
> I've yet to see anyone explain why this is an improvement over the
> current situation ?

"This" being ... ?

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)