[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1400796102-12832-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
Date: Fri, 23 May 2014 00:01:42 +0200
From: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
To: James Hogan <james.hogan@...tec.com>,
Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
Naoya Horiguchi <n-horiguchi@...jp.nec.com>,
linux-metag@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] arch: metag: mm: hugetlbpage.c: Cleaning up inconsistent NULL checks
Cleaning up inconsistent NULL checks.
There is otherwise a risk of a possible null pointer dereference.
Was largely found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
---
arch/metag/mm/hugetlbpage.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/metag/mm/hugetlbpage.c b/arch/metag/mm/hugetlbpage.c
index 0424315..3f8d5cd 100644
--- a/arch/metag/mm/hugetlbpage.c
+++ b/arch/metag/mm/hugetlbpage.c
@@ -188,7 +188,8 @@ new_search:
}
}
after_huge = 0;
- addr = ALIGN_HUGEPT(vma->vm_end);
+ if (vma)
+ addr = ALIGN_HUGEPT(vma->vm_end);
}
}
#endif
--
1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists