linux-kernel - Re: [PATCH RFC] Remove useless return variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 23 May 2014 02:47:16 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Peter Senna Tschudin <peter.senna@...il.com>
Cc:	Andi Kleen <andi@...stfloor.org>, trivial@...r.kernel.org,
	kernel-janitors@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	"kernelnewbies@...nelnewbies.org" <kernelnewbies@...nelnewbies.org>
Subject: Re: [PATCH RFC] Remove useless return variables

On Sun, May 18, 2014 at 5:14 AM, Peter Senna Tschudin
<peter.senna@...il.com> wrote:
> Added CC: trivial@...r.kernel.org
>
> On Sun, May 18, 2014 at 7:04 AM, Andi Kleen <andi@...stfloor.org> wrote:
>> Peter Senna Tschudin <peter.senna@...il.com> writes:
>>
>>> This patch remove variables that are initialized with a constant,
>>> are never updated, and are only used as parameter of return.
>>> Return the constant instead of using a variable.
>>
>> This ret variable pattern is pretty standard in Linux, as it makes it
>> easier to add new code that may trigger new errors
>> (using the usual "goto forest" error handling pattern)
> The average age in days of the return statements my patch changes is
> 1384, which is more than 3 years, so, in average, the plan of adding
> new code was lost...
> See: http://pastebin.com/2k13sHU2
>
>>
>> I don't see any benefit in whole-sale removing it. The compiler
>> doesn't care about it and will generate the same code in any
>> case.
> My goal is to make the code cleaner and easier to understand.
>
> Should I split this into a lot of patches?
>
>>
>> -Andi
>>
>> --
>> ak@...ux.intel.com -- Speaking for myself only
>
>
>
> --
> Peter

NAK on the drivers/net/ethernet/intel/i40e/i40e_dcb.c change because I
have patches currently in my queue that make the return variable
necessary.

-- 
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/