linux-kernel - Re: [PATCH] video: fbdev: grvga.c: Fix for possible null pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 23 May 2014 13:49:54 +0300
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
CC:	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <robh+dt@...nel.org>,
	Sachin Kamat <sachin.kamat@...aro.org>,
	Jingoo Han <jg1.han@...sung.com>,
	Daniel Vetter <daniel.vetter@...ll.ch>,
	<linux-fbdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<devicetree@...r.kernel.org>
Subject: Re: [PATCH] video: fbdev: grvga.c:  Fix for possible null pointer
 dereference

On 21/05/14 00:35, Rickard Strandqvist wrote:
> There is otherwise a risk of a possible null pointer dereference.
> 
> Was largely found by using a static code analysis program called cppcheck.
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
> ---
>  drivers/video/fbdev/grvga.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/video/fbdev/grvga.c b/drivers/video/fbdev/grvga.c
> index c078701..2db5bb1 100644
> --- a/drivers/video/fbdev/grvga.c
> +++ b/drivers/video/fbdev/grvga.c
> @@ -514,9 +514,10 @@ free_fb:
>  static int grvga_remove(struct platform_device *device)
>  {
>  	struct fb_info *info = dev_get_drvdata(&device->dev);
> -	struct grvga_par *par = info->par;
> +	struct grvga_par *par;
>  
>  	if (info) {
> +		par = info->par;
>  		unregister_framebuffer(info);
>  		fb_dealloc_cmap(&info->cmap);
>  

Thanks, queued this and the next one (video: fbdev: s3fb.c:  Fix for
possible null pointer dereference) for 3.16.

 Tomi




Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)