linux-kernel - Re: [PATCH] sound: soc: samsung: dma.c: Fix to remove null pointer checks that could never happen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHbNUh0cdV3-o+gQaKF3xKH77SRQLJkLGJTr660Bze8kQNDUfw@mail.gmail.com>
Date:	Fri, 23 May 2014 08:40:32 +0530
From:	Tushar Behera <tushar.behera@...aro.org>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc:	Ben Dooks <ben-linux@...ff.org>,
	Kukjin Kim <kgene.kim@...sung.com>,
	Sangbeom Kim <sbkim73@...sung.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	linux-samsung-soc <linux-samsung-soc@...r.kernel.org>,
	Linux-ALSA <alsa-devel@...a-project.org>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sound: soc: samsung: dma.c: Fix to remove null pointer
 checks that could never happen

On 23 May 2014 01:51, Rickard Strandqvist
<rickard_strandqvist@...ctrumdigital.se> wrote:
> Removal of null pointer checks that could never happen
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
> ---

The subject should probably be (at least should start with "ASoC: samsung:")
"ASoC: samsung: Remove redundant null pointer check from dma.c"

With that change,
Reviewed-by: Tushar Behera <tushar.behera@...aro.org>

>  sound/soc/samsung/dma.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/sound/soc/samsung/dma.c b/sound/soc/samsung/dma.c
> index dc09b71..0f17ae0 100644
> --- a/sound/soc/samsung/dma.c
> +++ b/sound/soc/samsung/dma.c
> @@ -124,8 +124,7 @@ static void audio_buffdone(void *data)
>                 if (prtd->dma_pos >= prtd->dma_end)
>                         prtd->dma_pos = prtd->dma_start;
>
> -               if (substream)
> -                       snd_pcm_period_elapsed(substream);
> +               snd_pcm_period_elapsed(substream);
>
>                 spin_lock(&prtd->lock);
>                 if (!samsung_dma_has_circular()) {
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Tushar Behera
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/