linux-kernel - Re: [PATCH v2] cpufreq: s5pv210: drop check for CONFIG_PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 23 May 2014 20:40:43 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Sachin Kamat <sachin.kamat@...aro.org>,
	"cpufreq@...r.kernel.org" <cpufreq@...r.kernel.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] cpufreq: s5pv210: drop check for CONFIG_PM_VERBOSE

On 23 May 2014 20:35, Paul Bolle <pebolle@...cali.nl> wrote:
> A pr_err() was added in v3.1. It was guarded by a check for
> CONFIG_PM_VERBOSE. The Kconfig symbol PM_VERBOSE was removed in v3.0. So
> this pr_err() has never been used. Drop that check and clean up the
> message a bit.
>
> Signed-off-by: Paul Bolle <pebolle@...cali.nl>
> ---
> v1 was called "cpufreq: s5pv210: remove unused call of pr_err()". v2
> keeps the pr_err() and trims down its arguments, as Sachin requested.
>
> Still untested.
>
>  drivers/cpufreq/s5pv210-cpufreq.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/cpufreq/s5pv210-cpufreq.c b/drivers/cpufreq/s5pv210-cpufreq.c
> index ab2c1a40d437..19a10b89fef7 100644
> --- a/drivers/cpufreq/s5pv210-cpufreq.c
> +++ b/drivers/cpufreq/s5pv210-cpufreq.c
> @@ -175,10 +175,8 @@ static int s5pv210_target(struct cpufreq_policy *policy, unsigned int index)
>         mutex_lock(&set_freq_lock);
>
>         if (no_cpufreq_access) {
> -#ifdef CONFIG_PM_VERBOSE
> -               pr_err("%s:%d denied access to %s as it is disabled"
> -                               "temporarily\n", __FILE__, __LINE__, __func__);
> -#endif
> +               pr_err("Denied access to %s as it is disabled temporarily\n",
> +                      __func__);
>                 ret = -EINVAL;
>                 goto exit;
>         }

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/