linux-kernel - Re: [PATCH 3/3] staging: panel: (coding style) Multiple assignments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 23 May 2014 20:33:46 +0900
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Dominique van den Broeck <domdevlin@...e.fr>
Cc:	Willy Tarreau <willy@...a-x.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] staging: panel: (coding style) Multiple assignments

On Wed, May 21, 2014 at 02:10:01PM +0200, Dominique van den Broeck wrote:
> Style-only modifications to comply with checkpatch.pl --strict --file. 
> . Breaks down compound assignments.
> 
> Signed-off-by: Dominique van den Broeck <domdevlin@...e.fr>
> ---
> Apply on linux-next tree, above:
> commit 4151fa6adc65da14673ece623bbb2acc6936f8be
> "Add linux-next specific files for 20140516"
> 
> diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
> index 1ac5e25..8d15b04 100644
> --- a/drivers/staging/panel/panel.c
> +++ b/drivers/staging/panel/panel.c
> @@ -664,8 +664,8 @@ static void pin_to_bits(int pin, unsigned char *d_val, unsigned char *c_val)
>  {
>  	int d_bit, c_bit, inv;
>  
> -	d_val[0] = c_val[0] = d_val[1] = c_val[1] = 0;
> -	d_val[2] = c_val[2] = 0xFF;
> +	d_val[0] = 0 ; c_val[0] = 0 ; d_val[1] = 0 ; c_val[1] = 0;
> +	d_val[2] = 0xFF; c_val[2] = 0xFF;

Honestly, that's harder to read now, so I'll just leave this all alone
and not apply this patch.

Becides, you got the ; wrong...

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/