linux-kernel - Re: [PATCH] staging: wlags49_h2: fix sparse warning "should it be static"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140523165335.GA6883@kroah.com>
Date:	Sat, 24 May 2014 01:53:35 +0900
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Luis Ortega <luiorpe1@...il.com>
Cc:	pe1dnn@...at.org, devel@...verdev.osuosl.org,
	josh@...htriplett.org, linux-kernel@...r.kernel.org,
	monamagarwal123@...il.com, paulmck@...ux.vnet.ibm.com,
	archanakumari959@...il.com
Subject: Re: [PATCH] staging: wlags49_h2: fix sparse warning "should it be
 static"

On Wed, May 07, 2014 at 06:31:48PM +0200, Luis Ortega wrote:
> Fixes the following warning:
> drivers/staging/wlags49_h2/sta_h2.c:4471:10: warning: symbol 'fw_image' was not declared. Should it be static?
> 
> Signed-off-by: Luis Ortega <luiorpe1@...il.com>
> ---
>  drivers/staging/wlags49_h2/sta_h2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/wlags49_h2/sta_h2.c b/drivers/staging/wlags49_h2/sta_h2.c
> index 0ba8def..2838faa 100644
> --- a/drivers/staging/wlags49_h2/sta_h2.c
> +++ b/drivers/staging/wlags49_h2/sta_h2.c
> @@ -4468,7 +4468,7 @@ static const CFG_RANGE20_STRCT fw_image_infocompat[] = {
>  	{ 0000, 0000, 0000, 0000, { { 0000, 0000, 0000 } } }	/* endsentinel */
>  };
> 
> -memimage fw_image = {
> +static memimage fw_image = {
>  	"FUPU7D37dhfwci\001C",			/* signature, <format number>, C/Bin type */
>  	(CFG_PROG_STRCT *) fw_image_code,
>  	0x000F368E,

ALWAYS test build your patches.  This patch breaks the build :(

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/