linux-kernel - Re: [PATCH] PM / devfreq: remove checks for CONFIG_EXYNOS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-id: <7638065.14871400820762911.JavaMail.weblogic@epml08>
Date:	Fri, 23 May 2014 04:52:45 +0000 (GMT)
From:	MyungJoo Ham <myungjoo.ham@...sung.com>
To:	Paul Bolle <pebolle@...cali.nl>,
	박경민 <kyungmin.park@...sung.com>,
	김국진 <kgene.kim@...sung.com>
Cc:	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-samsung-soc@...r.kernel.org" 
	<linux-samsung-soc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] PM / devfreq: remove checks for CONFIG_EXYNOS_ASV

On Thu, May 22, 2014 at 5:37 AM, Paul Bolle <pebolle@...cali.nl> wrote:
> Checks for CONFIG_EXYNOS_ASV were added in v3.3. But the related Kconfig
> symbol has never been added to the tree. Remove these checks, as they
> always evaluate to false.
>
> Signed-off-by: Paul Bolle <pebolle@...cali.nl>

Thanks for pointing this out.

ASV was supposed to be merged, but it appears it failed or never attempted.

I will merge with the next batch (this week).


Cheers,
MyungJoo.

> ---
> 0) Untested.
>
> 1) I do not really care much for this patch. Two years is not very long
> for dead code to remain in the tree. There is, however, a trivial issue
> that makes this patch stand out from the other patches in my current
> sweep of the tree for Kconfig related problems.
>
> See, here the use of an unknown Kconfig macro hides an obvious typo: it
> should either be "exynos_result_of_asv" or "exynos4_result_of_asv", but
> not both. Ie, this almost certainly wouldn't have compiled even if the
> Kconfig symbol EXYNOS_ASV would have been part of the tree.
>
> 2) So this makes me wonder whether there are any guidelines for using
> Kconfig macros before the related Kconfig symbols are merged?
>
>  drivers/devfreq/Kconfig              |  3 +--
>  drivers/devfreq/exynos/exynos4_bus.c | 13 -------------
>  2 files changed, 1 insertion(+), 15 deletions(-)