linux-kernel - Re: [PATCH] crypto: x86/sha1: fix coverity CID 1195603

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 24 May 2014 14:30:42 +0200
From:	Marek Vasut <marex@...x.de>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	Milos Vyletel <milos.vyletel@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	"maintainer:X86 ARCHITECTURE..." <x86@...nel.org>,
	"open list:CRYPTO API" <linux-crypto@...r.kernel.org>,
	"open list:X86 ARCHITECTURE..." <linux-kernel@...r.kernel.org>,
	linux-coverity@...r.kernel.org
Subject: Re: [PATCH] crypto: x86/sha1: fix coverity CID 1195603

On Thursday, May 08, 2014 at 03:30:25 PM, Herbert Xu wrote:
> On Wed, Apr 30, 2014 at 03:17:54PM -0400, Milos Vyletel wrote:
> > Coverity detected possible use of uninitialized pointer when printing
> > info message during module load. While this is higly unlikely to cause
> > any troubles simple change in sha1_ssse3_mod_init to make it look like
> > sha256/512 init function will fix this.
> > 
> > 260
> > 
> >    	6. Condition sha1_transform_asm, taking true branch
> > 
> > 261        if (sha1_transform_asm) {
> > 
> > CID 1195603 (#1 of 1): Uninitialized pointer read (UNINIT)
> > 7. uninit_use_in_call: Using uninitialized value algo_name when calling
> > printk. 262                pr_info("Using %s optimized SHA-1
> > implementation\n", algo_name); 263                return
> > crypto_register_shash(&alg);
> > 264        }
> > 
> > Reported-by: <scan-admin@...erity.com>
> > Signed-off-by: Milos Vyletel <milos.vyletel@...il.com>
> 
> Unless I'm missing something there is no way this code can use
> the variable without initialising it.
> 
> So this is a false positive and I'm not applying this.

I suppose changing the commit message to "align the code with sha256 ... NOTE: 
this also fixed CIDxyz." would work better and might get this applied ? I think 
unification of code is always good.

Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/