linux-kernel - Re: [PATCH] USB: cdc-acm: fix broken runtime suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 24 May 2014 12:59:07 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Johan Hovold <jhovold@...il.com>
Cc:	Jiri Slaby <jslaby@...e.cz>, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org, Peter Hurley <peter@...leysoftware.com>,
	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>,
	Xiao Jin <jin.xiao@...el.com>, david.a.cohen@...ux.intel.com,
	yanmin.zhang@...el.com, Oliver Neukum <oneukum@...e.de>
Subject: Re: [PATCH] USB: cdc-acm: fix broken runtime suspend

On Sat, May 24, 2014 at 04:42:42PM +0200, Johan Hovold wrote:
> On Mon, Apr 14, 2014 at 09:58:12PM +0200, Johan Hovold wrote:
> > The current ACM runtime-suspend implementation is broken in several
> > ways:
> > 
> > Firstly, it buffers only the first write request being made while
> > suspended -- any further writes are silently dropped.
> > 
> > Secondly, writes being dropped also leak write urbs, which are never
> > reclaimed (until the device is unbound).
> > 
> > Thirdly, even the single buffered write is not cleared at shutdown
> > (which may happen before the device is resumed), something which can
> > lead to another urb leak as well as a PM usage-counter leak.
> > 
> > Fix this by implementing a delayed-write queue using urb anchors and
> > making sure to discard the queue properly at shutdown.
> > 
> > Reported-by: Xiao Jin <jin.xiao@...el.com>
> > Signed-off-by: Johan Hovold <jhovold@...il.com>
> 
> Greg, 
> 
> I understand yoǘ're on your way home from Japan and are getting ready to
> work through the 3.16 patch queue.
> 
> Could you please discard this one for now? I've found a couple of more
> PM related problems and I'll submit a slight update of this one as part
> of a larger series of fixes instead.

I think it's already in my tree, right?  I don't see it in my to-apply
queue.  Can you send me the git id to revert, or just a patch that
reverts it?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/