linux-kernel - Re: [PATCH net-next 2/4] bridge: adhere to querier election mechanism specified by RFCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140523.233637.1826798421419100755.davem@davemloft.net>
Date:	Fri, 23 May 2014 23:36:37 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	linus.luessing@....de
Cc:	netdev@...r.kernel.org, bridge@...ts.linux-foundation.org,
	stephen@...workplumber.org, linux-kernel@...r.kernel.org,
	b.a.t.m.a.n@...ts.open-mesh.org
Subject: Re: [PATCH net-next 2/4] bridge: adhere to querier election
 mechanism specified by RFCs

From: Linus Lüssing <linus.luessing@....de>
Date: Wed, 21 May 2014 10:59:00 +0200

> +	if (saddr <= br->ip4_querier.addr.u.ip4)
> +		goto update;

It is clear to me that you should be making these comparisons in cpu
endianness.

Otherwise the code will handle the same situations differently
on big-endian vs. little-endian machines.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/