linux-kernel - Re: [PATCH 1/1] lib/bug.c: convert printk to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1400913343.10357.9.camel@joe-AO725>
Date:	Fri, 23 May 2014 23:35:43 -0700
From:	Joe Perches <joe@...ches.com>
To:	Fabian Frederick <fabf@...net.be>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	akpm <akpm@...ux-foundation.org>
Subject: Re: [PATCH 1/1] lib/bug.c: convert printk to pr_foo()

On Sat, 2014-05-24 at 08:18 +0200, Fabian Frederick wrote:
> -Coalesce formats
> -"WARNING:" prefix unchanged to keep bug format.
> -printk(KERN_DEFAULT not converted.

Hello Fabian.

For these conversions where there is a specific
desire to _NOT_ have a prefix, can you please add
a new #define to the file?

#define pr_fmt(fmt) fmt

so that if ever the default in printk.h is changed,
these will not be prefixed.

> diff --git a/lib/bug.c b/lib/bug.c
[]
> @@ -153,15 +153,13 @@ enum bug_trap_type report_bug(unsigned long bugaddr, struct pt_regs *regs)
>  
>  	if (warning) {
>  		/* this is a WARN_ON rather than BUG/BUG_ON */
> -		printk(KERN_WARNING "------------[ cut here ]------------\n");
> +		pr_warn("------------[ cut here ]------------\n");

Thanks, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/