linux-kernel - Re: [PATCH linux-next] DRM: Armada: update dma_buf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140526090623.77186cdf@canb.auug.org.au>
Date:	Mon, 26 May 2014 09:06:23 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
Cc:	David Herrmann <dh.herrmann@...il.com>,
	Vincent Stehlé <vincent.stehle@...oste.net>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	"linux-next@...r.kernel.org" <linux-next@...r.kernel.org>,
	David Airlie <airlied@...ux.ie>,
	Maarten Lankhorst <maarten.lankhorst@...onical.com>,
	Sumit Semwal <sumit.semwal@...aro.org>
Subject: Re: [PATCH linux-next] DRM: Armada: update dma_buf_export use

Hi all,

On Sun, 25 May 2014 23:54:35 +0100 Russell King - ARM Linux <linux@....linux.org.uk> wrote:
>
> On Sun, May 25, 2014 at 02:08:48PM +0200, David Herrmann wrote:
> > 
> > On Sat, May 24, 2014 at 11:05 PM, Vincent Stehlé
> > <vincent.stehle@...oste.net> wrote:
> > > The dma_buf_export function was updated in commit 4bcec44ffaf9 'dma-buf: use
> > > reservation objects' to take a reservation object parameter; update Armada
> > > export method accordingly.
> > >
> > > This fixes the following compilation error:
> > >
> > >   drivers/gpu/drm/armada/armada_gem.c: In function ‘armada_gem_prime_export’:
> > >   drivers/gpu/drm/armada/armada_gem.c:544:16: error: macro "dma_buf_export" requires 5 arguments, but only 4 given
> > >
> > > Signed-off-by: Vincent Stehlé <vincent.stehle@...oste.net>
> > > Cc: Russell King <rmk+kernel@....linux.org.uk>
> > > Cc: David Airlie <airlied@...ux.ie>
> > > Cc: Maarten Lankhorst <maarten.lankhorst@...onical.com>
> > > Cc: Sumit Semwal <sumit.semwal@...aro.org>
> > 
> > Reviewed-by: David Herrmann <dh.herrmann@...il.com>
> 
> Acked-by: Russell King <rmk+kernel@....linux.org.uk>
> 
> Airlied, can you merge this please?  Thanks.

Except that commit 4bcec44ffaf9 'dma-buf: use reservation objects'
comes from the dma-buf tree, so Sumit needs to add this commit to his
tree.

> > > This can be seen with e.g. linux next-20140523 and arm allmodconfig.
> > >
> > > Best regards,
> > >
> > > V.
> > >
> > >  drivers/gpu/drm/armada/armada_gem.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/armada/armada_gem.c b/drivers/gpu/drm/armada/armada_gem.c
> > > index 887816f..7adb0c3 100644
> > > --- a/drivers/gpu/drm/armada/armada_gem.c
> > > +++ b/drivers/gpu/drm/armada/armada_gem.c
> > > @@ -541,7 +541,7 @@ armada_gem_prime_export(struct drm_device *dev, struct drm_gem_object *obj,
> > >         int flags)
> > >  {
> > >         return dma_buf_export(obj, &armada_gem_prime_dmabuf_ops, obj->size,
> > > -                             O_RDWR);
> > > +                             O_RDWR, NULL);
> > >  }
> > >
> > >  struct drm_gem_object *
> > > --
> > > 2.0.0.rc2

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)