linux-kernel - Re: Extend irq_set_affinity_notifier() to use a call chain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5381EAB5.90402@gmail.com>
Date:	Sun, 25 May 2014 16:05:57 +0300
From:	Amir Vadai <amirv.mellanox@...il.com>
To:	Thomas Gleixner <tglx@...utronix.de>,
	Ben Hutchings <ben@...adent.org.uk>,
	"David S. Miller" <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Or Gerlitz <ogerlitz@...lanox.com>, idos@...lanox.com,
	Yevgeny Petrilin <yevgenyp@...lanox.com>
Subject: Re: Extend irq_set_affinity_notifier() to use  a call chain

On 5/25/2014 3:15 PM, Amir Vadai wrote:
> Hi,
>
> I'm working for Mellanox on mlx4_en NIC driver.
>
> We need to be able to be notified on irq affinity changes.
> This is because, during non-stop full bandwidth traffic, napi will poll
> constantly and no interrupt will be fired. Because of that, even if the
> user changes the irq affinity, polling will continue to be done on the
> original CPU that was chosen on the first packet.
> We would like to be notified when the affinity is changed. When such an
> event happen, the driver will arm the interrupts and end the napi
> session. An interrupt will start a new napi session on the right CPU.
>
> In order to do that, I need to add a new irq affinity notification
> callback (In addition to the existing cpu_rmap notification). For that I
> would like to extend irq_set_affinity_notifier() to have a notifier
> call-chain instead of a single notifier callback.
>
> I wanted to hear your opinion on this, and unless there is a better
> solution, will send an RFC later on.
>
> References:
> - http://patchwork.ozlabs.org/patch/65244/ - Review done by Thomas
> Glexiber to Ben Hutchings first version of the irq affinity notifiers.
> - http://patchwork.ozlabs.org/patch/79593/ - Final version of
> irq_set_affinity_notifier() that was applied
>
> Thanks,
> Amir

Didn't mention that a patch to set irq affinity notifier was already 
added to mlx4_en [1], and now aRFS is broken because cpu_rmap callback 
is dropped when mlx4_en callback is set.

[1] - http://patchwork.ozlabs.org/patch/348669/

Amir

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/