lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 25 May 2014 14:15:23 -0500 From: minyard@....org To: linux-rt-users@...r.kernel.org, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org Cc: Corey Minyard <cminyard@...sta.com> Subject: [PATCH] arm: Set hardirq tracing to on when idling From: Corey Minyard <cminyard@...sta.com> The CPU will go to idle with interrupts off, but the interrupts will wake up the idle. This was causing very long irqsoff trace values because, basically, the whole idle time was traces with irqs off, even though they weren't really off. Rework the idle code to turn hardirq tracing to on befor calling idle. Signed-off-by: Corey Minyard <cminyard@...sta.com> --- arch/arm/kernel/process.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) I'm not sure this is correct for all ARM boards, but it fixes the issue for the Vexpress board I have. No more 4 second irqsoff times. diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c index 1ca6cf1..92413af 100644 --- a/arch/arm/kernel/process.c +++ b/arch/arm/kernel/process.c @@ -133,11 +133,12 @@ void (*arm_pm_idle)(void); static void default_idle(void) { + trace_hardirqs_on(); if (arm_pm_idle) arm_pm_idle(); else cpu_do_idle(); - local_irq_enable(); + raw_local_irq_enable(); } void arch_cpu_idle_prepare(void) -- 1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists