linux-kernel - Re: [PATCH] Staging: Silicom: bpctl_mod.c & bypass.c: Adding blank lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140526005151.GB3129@kroah.com>
Date:	Sun, 25 May 2014 17:51:51 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Chaitanya Hazarey <c@...io>
Cc:	chad@...c.us, michael.banken@...he.stud.uni-erlangen.de,
	dan.carpenter@...cle.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: Silicom: bpctl_mod.c & bypass.c: Adding blank
 lines

On Sun, May 25, 2014 at 05:36:58PM -0700, Chaitanya Hazarey wrote:
> Added a blank line after declarations in many places to fix the following warning issued by checkpatch.pl:

Always wrap your lines at 72 columns, like git asks you to when you type
in the commit message.

> WARNING: Missing a blank line after declarations
> 
> The reason why it was not applying clean against Greg's tree was that bpctl_mod.c had changed in the functions which are a part of this patch. 

This doesn't belong as part of the changelog, right?  Please resend and
put it below the --- line, if you want to.

Can you redo this with the changelog fixed up please?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/