linux-kernel - Re: [PATCH 1/3] staging: panel: (coding style) Matching braces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1401115505.7240.11.camel@wisdom>
Date:	Mon, 26 May 2014 16:45:05 +0200
From:	Dominique van den Broeck <domdevlin@...e.fr>
To:	Willy Tarreau <w@....eu>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] staging: panel: (coding style) Matching braces

Hello Willy,

> I don't want to be nit-picking, but since we're talking about style...
> for me these "} else {" statements are harder to parse than having them
> on two lines this way :
> <...>
>
> It's just a matter of taste I know, but for me they read easier, probably
> because the braces do not affect alignment and the lines appear exactly
> similar with or without the braces.

I don't mind at all about this. 

Even if I'm into C code for quite a long time now, I'm still new in kernel
development (just completed the Eudyptula Challenge) and I thought it could
be both a harmless and useful way to start contributing and get used with it
to focus a bit on ./checkpatch.pl suggestions (which is the actual entity to
blame about it).

This is the reason why I submitted the patch but it's not a personal
preference. If you prefer these braces laid out the older way, I'll let
them as is next time. If there's another usages I should know about, just
let me know.

Cheers.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/