linux-kernel - Re: [PATCH] watchdog: kempld-wdt: Use the correct value when configuring the prescaler with the watchdog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20140526185959.GA21481@spo001.leaseweb.com>
Date:	Mon, 26 May 2014 20:59:59 +0200
From:	Wim Van Sebroeck <wim@...ana.be>
To:	Per Gundberg <per.gundberg@...mera.com>
Cc:	linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: kempld-wdt: Use the correct value when configuring the prescaler with the watchdog

Hi Per,

> Use the prescaler index, rather than its value, to configure the watchdog.
> This will prevent a mismatch with the prescaler used to calculate the
> cycles.
> 
> Signed-off-by: Per Gundberg <per.gundberg@...mera.com>
> ---
>  drivers/watchdog/kempld_wdt.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- src/drivers/watchdog/kempld_wdt.c.orig    2014-04-24 07:32:08.463745055
> +0000
> +++ src/drivers/watchdog/kempld_wdt.c    2014-04-24 07:34:09.839739808 +0000
> @@ -163,7 +163,7 @@ static int kempld_wdt_set_stage_timeout(
>      kempld_get_mutex(pld);
>      stage_cfg = kempld_read8(pld, KEMPLD_WDT_STAGE_CFG(stage->id));
>      stage_cfg &= ~STAGE_CFG_PRESCALER_MASK;
> -    stage_cfg |= STAGE_CFG_SET_PRESCALER(prescaler);
> +    stage_cfg |= STAGE_CFG_SET_PRESCALER(PRESCALER_21);
>      kempld_write8(pld, KEMPLD_WDT_STAGE_CFG(stage->id), stage_cfg);
>      kempld_write32(pld, KEMPLD_WDT_STAGE_TIMEOUT(stage->id),
>              stage_timeout);

This patch has been added to linux-watchdog-next.

Kind regards,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/