linux-kernel - Re: [PATCH 3/3] watchdog: via_wdt: replace del_timer by del_timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 26 May 2014 20:49:04 +0200
From:	Wim Van Sebroeck <wim@...ana.be>
To:	Julia Lawall <Julia.Lawall@...6.fr>
Cc:	kernel-janitors@...r.kernel.org, linux-watchdog@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] watchdog: via_wdt: replace del_timer by del_timer_sync

Hi Julia,

> From: Julia Lawall <Julia.Lawall@...6.fr>
> 
> Use del_timer_sync to ensure that the timer is stopped on all CPUs before
> the driver exits.
> 
> This change was suggested by Thomas Gleixner.
> 
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @r@
> identifier i,t,ex;
> @@
> struct t i = { .remove = ex, };
> 
> @@
> identifier r.ex;
> @@
> ex(...) {
>   <...
> - del_timer
> + del_timer_sync
>     (...)
>   ...>
> }
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>
> 
> ---
> Not tested.
> 
>  drivers/watchdog/via_wdt.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/via_wdt.c b/drivers/watchdog/via_wdt.c
> index d2cd9f0..56369c4 100644
> --- a/drivers/watchdog/via_wdt.c
> +++ b/drivers/watchdog/via_wdt.c
> @@ -232,7 +232,7 @@ err_out_disable_device:
>  static void wdt_remove(struct pci_dev *pdev)
>  {
>  	watchdog_unregister_device(&wdt_dev);
> -	del_timer(&timer);
> +	del_timer_sync(&timer);
>  	iounmap(wdt_mem);
>  	release_mem_region(mmio, VIA_WDT_MMIO_LEN);
>  	release_resource(&wdt_res);
> 

This was added 2 or 3 weeks ago to linux-watchdog-next.

Kind regards,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/