linux-kernel - Re: [PATCH v7 1/6] SP800-90A Deterministic Random Bit Generator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 26 May 2014 07:44:15 +0200
From:	Stephan Mueller <smueller@...onox.de>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
	aquini@...hat.com, jeremy.wayne.powell@...il.com,
	clemens@...isch.de, pwalten@....ibm.com, joe@...ches.com
Subject: Re: [PATCH v7 1/6] SP800-90A Deterministic Random Bit Generator

Am Samstag, 24. Mai 2014, 05:10:07 schrieb Herbert Xu:

Hi Herbert,

> Stephan Mueller <smueller@...onox.de> wrote:
> > +       memset(&drbg_algs[i], 0, sizeof(struct crypto_alg));
> > +       if (pr) {
> > +               memcpy(drbg_algs[i].cra_name, "drbg(pr(", 8);
> > +               memcpy(drbg_algs[i].cra_driver_name, "drbg_pr_", 8);
> > +               pos = 8;
> 
> You shouldn't use the brackets here since this not a real template.
> Just use one name for both cra_name and cra_driver_name.

Thanks for the hint: I would use the name specified for cra_driver_name also 
for cra_name
> 
> Cheers,


Ciao
Stephan
-- 
| Cui bono? |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/