| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <87ha4biv1t.fsf@intel.com>
Date: Tue, 27 May 2014 09:40:14 +0300
From: Jani Nikula <jani.nikula@...ux.intel.com>
To: Benoit Taine <benoit.taine@...6.fr>,
David Airlie <airlied@...ux.ie>
Cc: benoit.taine@...6.fr, kernel-janitors@...r.kernel.org,
linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH 13/18] drm/edid: Use kmemdup instead of kmalloc + memcpy
On Mon, 26 May 2014, Benoit Taine <benoit.taine@...6.fr> wrote:
> This issue was reported by coccicheck using the semantic patch
> at scripts/coccinelle/api/memdup.cocci
Reviewed-by: Jani Nikula <jani.nikula@...el.com>
>
> Signed-off-by: Benoit Taine <benoit.taine@...6.fr>
> ---
> Tested by compilation without errors.
>
> drivers/gpu/drm/drm_edid.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index 7a4fd2e..d74239f 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -3228,10 +3228,9 @@ int drm_edid_to_speaker_allocation(struct edid *edid, u8 **sadb)
>
> /* Speaker Allocation Data Block */
> if (dbl == 3) {
> - *sadb = kmalloc(dbl, GFP_KERNEL);
> + *sadb = kmemdup(&db[1], dbl, GFP_KERNEL);
> if (!*sadb)
> return -ENOMEM;
> - memcpy(*sadb, &db[1], dbl);
> count = dbl;
> break;
> }
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Jani Nikula, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists