linux-kernel - Re: fs/dcache.c - BUG: soft lockup - CPU#5 stuck for 22s! [systemd-udevd:1667]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140527070409.GA1801@lahna.fi.intel.com>
Date:	Tue, 27 May 2014 10:04:09 +0300
From:	Mika Westerberg <mika.westerberg@...ux.intel.com>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Miklos Szeredi <mszeredi@...e.cz>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>
Subject: Re: fs/dcache.c - BUG: soft lockup - CPU#5 stuck for 22s!
 [systemd-udevd:1667]

On Tue, May 27, 2014 at 05:00:26AM +0100, Al Viro wrote:
> On Tue, May 27, 2014 at 04:14:15AM +0100, Al Viro wrote:
> 
> > As the matter of fact, let's try this instead - retry the same sucker
> > immediately in case if trylocks fail.  Comments?
> 
> Better yet, let's take "move back to shrink list" into dentry_kill()
> itself.  Then we get consistent locking rules for dentry_kill() and
> instead of unlock_on_failure we simply pass it NULL or the shrink
> list to put the sucker back.  Mika, could you test this one and see
> if it fixes that livelock?  The difference in behaviour is that in
> case of trylock failure we hit that sucker again without letting
> it ride all the way around the list, same as we do for other dentry_kill()
> callers.

I tried this patch and unfortunately it still results the same sort of
livelock. I've attached the dmesg.

I also tried the serialization patch from Linus and it seemed to fix the
problem. After several rounds of USB memory stick plug/unplug I haven't
seen a single "soft lockup" warning in dmesg.

I'm able to reproduce the problem pretty easily, so if you have
something else to try I'm more than happy to give it a try.

View attachment "dmesg.al" of type "text/plain" (125170 bytes)