linux-kernel - Re: [PATCH v3] clk: shmobile: mstp: Fix the is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdUO+avQtRQ2zwqiCZwtnGubC3M-7+VHR4NXjft4P4FDnw@mail.gmail.com>
Date:	Tue, 27 May 2014 10:04:16 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Magnus Damm <magnus.damm@...il.com>
Cc:	Geert Uytterhoeven <geert+renesas@...der.be>,
	Mike Turquette <mturquette@...aro.org>,
	SH-Linux <linux-sh@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>
Subject: Re: [PATCH v3] clk: shmobile: mstp: Fix the is_enabled() operation

Hi Magnus,

On Tue, May 27, 2014 at 3:02 AM, Magnus Damm <magnus.damm@...il.com> wrote:
> On Fri, May 23, 2014 at 3:02 AM, Geert Uytterhoeven
> <geert+renesas@...der.be> wrote:
>> From: Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>
>>
>> The MSTP[SC]R registers have clock stop bits, not clock enable bits. The
>> bit value should thus be inverted in the is_enabled() operation.
>>
>> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
>> Cc: Mike Turquette <mturquette@...aro.org>
>> ---
>> v3:
>>   - This depends on commit 3c90c55dcde745bed81f6447f24ba96bda43d984
>>     ("drivers: sh: compile drivers/sh/pm_runtime.c if
>>     ARCH_SHMOBILE_MULTI"), which has entered mainline in v3.15-rc6.
>
> Thanks for resubmitting this fix. Do you intend to get this included
> in v3.15 (seems unlikely) or is your target v3.16?

3.16 is OK. The only ill effect is that some clocks may be enabled,
while they're
not needed.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/