linux-kernel - Re: [PATCH v8 3/3] ARM: sunxi: Add IR controller support in DT on A20

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140527091337.GJ4730@lukather>
Date:	Tue, 27 May 2014 11:13:37 +0200
From:	Maxime Ripard <maxime.ripard@...e-electrons.com>
To:	Alexander Bersenev <bay@...kerdom.ru>
Cc:	linux-sunxi@...glegroups.com, david@...deman.nu,
	devicetree@...r.kernel.org, galak@...eaurora.org,
	grant.likely@...aro.org, ijc+devicetree@...lion.org.uk,
	james.hogan@...tec.com, linux-arm-kernel@...ts.infradead.org,
	linux@....linux.org.uk, m.chehab@...sung.com, mark.rutland@....com,
	pawel.moll@....com, rdunlap@...radead.org, robh+dt@...nel.org,
	sean@...s.org, srinivas.kandagatla@...com,
	wingrime@...ux-sunxi.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-media@...r.kernel.org
Subject: Re: [PATCH v8 3/3] ARM: sunxi: Add IR controller support in DT on A20

On Mon, May 26, 2014 at 04:26:45AM +0600, Alexander Bersenev wrote:
> This patch adds IR controller in A20 Device-Tree:
> - Two IR devices found in A20 user manual
> - Pins for two devices
> - One IR device physically found on Cubieboard 2
> - One IR device physically found on Cubietruck
> 
> Signed-off-by: Alexander Bersenev <bay@...kerdom.ru>
> Signed-off-by: Alexsey Shestacov <wingrime@...ux-sunxi.org>
> ---
>  arch/arm/boot/dts/sun7i-a20-cubieboard2.dts |  6 ++++++
>  arch/arm/boot/dts/sun7i-a20-cubietruck.dts  |  6 ++++++
>  arch/arm/boot/dts/sun7i-a20.dtsi            | 32 +++++++++++++++++++++++++++++

I told you numerous times already that I wanted this patch to be split
into at least three of them:
  - One to add the device to the DTSI.
  - One to add the pins
  - and one to enable the devices in the DTS.

Please address this comment.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)