linux-kernel - Re: [PATCH V3] bio: modify __bio_add_page() to accept pages that don't start a new segment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACVXFVNSZ7+MxW8-SiLXUFW6pGJ7b-OQzf8-KLzcXyE7BvhbbA@mail.gmail.com>
Date:	Tue, 27 May 2014 18:15:45 +0800
From:	Ming Lei <tom.leiming@...il.com>
To:	Maurizio Lombardi <mlombard@...hat.com>
Cc:	Al Viro <viro@...iv.linux.org.uk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux FS Devel <linux-fsdevel@...r.kernel.org>,
	"James E.J. Bottomley" <JBottomley@...allels.com>,
	Christoph Hellwig <hch@....de>,
	Linux SCSI List <linux-scsi@...r.kernel.org>,
	Kent Overstreet <kmo@...erainc.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	m.lombardi85@...il.com
Subject: Re: [PATCH V3] bio: modify __bio_add_page() to accept pages that
 don't start a new segment

Hi Maurizio,

On Thu, May 1, 2014 at 9:56 PM, Maurizio Lombardi <mlombard@...hat.com> wrote:
> The original behaviour is to refuse to add a new page if the maximum number
> of segments has been reached, regardless of the fact the page we are
> going to add can be merged into the last segment or not.

If the page can be merged to last segment, it should have been
covered by code in branch of 'if (bio->bi_vcnt > 0) ...', shouldn't it?

Or maybe it is better to make that code cover your case since
looks your case is similar with that one according to your commit
log.


Thanks,
-- 
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/