linux-kernel - Re: [PATCH] of: handle NULL node in of_get_next_available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140527111930.696AAC4156C@trevor.secretlab.ca>
Date:	Tue, 27 May 2014 12:19:30 +0100
From:	Grant Likely <grant.likely@...aro.org>
To:	Florian Fainelli <f.fainelli@...il.com>, devicetree@...r.kernel.org
Cc:	Florian Fainelli <f.fainelli@...il.com>,
	Daniel Mack <zonque@...il.com>,
	Rob Herring <robh+dt@...nel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] of: handle NULL node in of_get_next_available_child

On Fri, 23 May 2014 12:43:11 -0700, Florian Fainelli <f.fainelli@...il.com> wrote:
> Add an early check for the node argument in
> of_get_next_available_child() to avoid dereferencing a NULL node pointer
> a few lines after.
> 
> CC: Daniel Mack <zonque@...il.com>
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Is there a bug that exposed this path? I'd like some more justification
before merging this patch, particularly considering of_get_next_child()
doesn't check for it either, but you're not modifying that function.

g.

> ---
>  drivers/of/base.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/of/base.c b/drivers/of/base.c
> index e67b308819c9..9a71bfac78ae 100644
> --- a/drivers/of/base.c
> +++ b/drivers/of/base.c
> @@ -746,6 +746,9 @@ struct device_node *of_get_next_available_child(const struct device_node *node,
>  	struct device_node *next;
>  	unsigned long flags;
>  
> +	if (!node)
> +		return NULL;
> +
>  	raw_spin_lock_irqsave(&devtree_lock, flags);
>  	next = prev ? prev->sibling : node->child;
>  	for (; next; next = next->sibling) {
> -- 
> 1.9.1
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/