linux-kernel - Re: [PATCH] Input: atmel_mxt_ts - fix build error in mxt_read_t9

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20140527020948.GD12890@core.coreip.homeip.net>
Date:	Mon, 26 May 2014 19:09:48 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Nick Dyer <nick.dyer@...ev.co.uk>
Cc:	sfr@...b.auug.org.au, linux-next@...r.kernel.org,
	linux-kernel@...r.kernel.org, Nick Dyer <nick.dyer@...ev.co.uk>
Subject: Re: [PATCH] Input: atmel_mxt_ts - fix build error in
 mxt_read_t9_resolution

On Tue, May 20, 2014 at 10:26:51AM +0100, Nick Dyer wrote:
> Stephen Rothwell reports this build error:
> 
> drivers/input/touchscreen/atmel_mxt_ts.c: In function 'mxt_read_t9_resolution':
> drivers/input/touchscreen/atmel_mxt_ts.c:1043:2: warning: passing argument 1 of '__swab16s' makes pointer from integer without a cast [enabled by default]
>   le16_to_cpus(range.x);
>   ^
> 
> I believe this is a correct fix.
> 
> Signed-off-by: Nick Dyer <nick.dyer@...ev.co.uk>
> ---
>  drivers/input/touchscreen/atmel_mxt_ts.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c
> index d8ea3ed..97495c7 100644
> --- a/drivers/input/touchscreen/atmel_mxt_ts.c
> +++ b/drivers/input/touchscreen/atmel_mxt_ts.c
> @@ -1040,8 +1040,8 @@ static int mxt_read_t9_resolution(struct mxt_data *data)
>  	if (error)
>  		return error;
>  
> -	le16_to_cpus(range.x);
> -	le16_to_cpus(range.y);
> +	le16_to_cpus(&range.x);
> +	le16_to_cpus(&range.y);
>  
>  	error =  __mxt_read_reg(client,
>  				object->start_address + MXT_T9_ORIENT,
> -- 
> 1.8.3.2
> 

Thank you, I folded it into the offending patch.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/