linux-kernel - RE: [RFT][PATCH] regulator: pfuze100: Support enable/disable for fixed regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cf4da38b716044d598a0e3b77f403f39@BLUPR03MB036.namprd03.prod.outlook.com>
Date:	Tue, 27 May 2014 03:05:35 +0000
From:	Yibin Gong <yibin.gong@...escale.com>
To:	Axel Lin <axel.lin@...ics.com>, Mark Brown <broonie@...nel.org>
CC:	"Fabio.Estevam@...escale.com" <Fabio.Estevam@...escale.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [RFT][PATCH] regulator: pfuze100: Support enable/disable for
 fixed regulator

Tested-by: Robin Gong <b38343@...escale.com>
Acked-by: Robin Gong <b38343@...escale.com>

-----Original Message-----
From: Axel Lin [mailto:axel.lin@...ics.com] 
Sent: Monday, May 26, 2014 5:56 PM
To: Mark Brown
Cc: Gong Yibin-B38343; Estevam Fabio-R49496; Liam Girdwood; linux-kernel@...r.kernel.org
Subject: [RFT][PATCH] regulator: pfuze100: Support enable/disable for fixed regulator

Current code has .enable_reg and .enable_mask settings, but the implementation for corresponding callbacks are missing. Fix it.

Signed-off-by: Axel Lin <axel.lin@...ics.com>
---
Hi Robin,
Can you review and test this patch?
Thanks,
Axel

 drivers/regulator/pfuze100-regulator.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/regulator/pfuze100-regulator.c b/drivers/regulator/pfuze100-regulator.c
index 67e678c..b6b4529 100644
--- a/drivers/regulator/pfuze100-regulator.c
+++ b/drivers/regulator/pfuze100-regulator.c
@@ -125,6 +125,9 @@ static struct regulator_ops pfuze100_ldo_regulator_ops = {  };
 
 static struct regulator_ops pfuze100_fixed_regulator_ops = {
+	.enable = regulator_enable_regmap,
+	.disable = regulator_disable_regmap,
+	.is_enabled = regulator_is_enabled_regmap,
 	.list_voltage = regulator_list_voltage_linear,  };
 
--
1.8.3.2