linux-kernel - Re: [PATCH 3.14-rt] sched/numa: Fix task_numa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140527145349.0bc2030e@gandalf.local.home>
Date:	Tue, 27 May 2014 14:53:49 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	Mike Galbraith <umgwanakikbuti@...il.com>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	linux-rt-users <linux-rt-users@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	John Kacur <jkacur@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Sasha Levin <sasha.levin@...cle.com>
Subject: Re: [PATCH 3.14-rt] sched/numa: Fix task_numa_free() lockdep splat

On Tue, 27 May 2014 14:52:01 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

 
> Ah crap. I did a search on all the callers of put_task_struct(), and
> somehow missed this one.  Yep, I was looking for places that called
> this while holding other irq safe locks.
> 

Anyway, this nicely answers Mike's question to why it causes lockdep
splat. There exists a location that calls put_task_struct() with irqs
disabled (not to mention holding irq unsafe locks).

I was having problems just finding a place that called it with irqs off.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/