linux-kernel - Re: [PATCH] block: mq flush: fix race between IPI handler and mq flush worker

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5384DF5E.3020304@kernel.dk>
Date:	Tue, 27 May 2014 12:54:22 -0600
From:	Jens Axboe <axboe@...nel.dk>
To:	Christoph Hellwig <hch@....de>
CC:	Ming Lei <tom.leiming@...il.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	stable <stable@...r.kernel.org>
Subject: Re: [PATCH] block: mq flush: fix race between IPI handler and mq
 flush worker

On 2014-05-27 12:53, Christoph Hellwig wrote:
> On Tue, May 27, 2014 at 12:38:15PM -0600, Jens Axboe wrote:
>> On 2014-05-27 12:13, Christoph Hellwig wrote:
>>> Here is my counter proposal that requeues via two lists and a work struct
>>> in the request_queue.  I've also tested it with scsi-mq.
>>>
>>
>> I like this, moves the state out of the request. But how about we
>> consolidate the two requeue requests lists, and just mark the request as
>> needing head insertion instead? Just add a cmd_flags flag, REQ_REQUEUE_HEAD
>> or something.
>
> That should be doable, just didn't like introducing even more flags.

Space is plenty big again now... The down side is that the splice trick 
wont work, but if we have more than a few requests on the requeue list, 
we're doing it wrong anyway.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/