linux-kernel - Re: [PATCH v2] tracing: Don't account for cpu idle time with irqsoff tracers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 27 May 2014 22:11:25 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Stephen Boyd <sboyd@...eaurora.org>
Cc:	Steven Rostedt <rostedt@...dmis.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
	Corey Minyard <cminyard@...sta.com>,
	Stanislav Meduna <stano@...una.org>
Subject: Re: [PATCH v2] tracing: Don't account for cpu idle time with irqsoff tracers

On Tuesday 27 May 2014 13:08:04 Stephen Boyd wrote:
> @@ -380,7 +382,7 @@ start_critical_timing(unsigned long ip, unsigned long parent_ip)
>  
>         cpu = raw_smp_processor_id();
>  
> -       if (per_cpu(tracing_cpu, cpu))
> +       if (per_cpu(timings_stopped, cpu) || per_cpu(tracing_cpu, cpu))
>                 return;
>  
>         data = per_cpu_ptr(tr->trace_buffer.data, cpu);
> 

Where exactly do you see other code calling here while
per_cpu(timings_stopped) is set? Would it be possible to just
change that call site?

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/