linux-kernel - Re: [PATCH] of: handle NULL node in of_get_next_available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140527201711.553B8C40BD2@trevor.secretlab.ca>
Date:	Tue, 27 May 2014 21:17:11 +0100
From:	Grant Likely <grant.likely@...aro.org>
To:	Florian Fainelli <f.fainelli@...il.com>
Cc:	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Daniel Mack <zonque@...il.com>,
	Rob Herring <robh+dt@...nel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] of: handle NULL node in of_get_next_available_child

On Tue, 27 May 2014 10:36:10 -0700, Florian Fainelli <f.fainelli@...il.com> wrote:
> Hi Grant,
> 
> 2014-05-27 4:19 GMT-07:00 Grant Likely <grant.likely@...aro.org>:
> > On Fri, 23 May 2014 12:43:11 -0700, Florian Fainelli <f.fainelli@...il.com> wrote:
> >> Add an early check for the node argument in
> >> of_get_next_available_child() to avoid dereferencing a NULL node pointer
> >> a few lines after.
> >>
> >> CC: Daniel Mack <zonque@...il.com>
> >> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> >
> > Is there a bug that exposed this path?
> 
> Daniel sent a patch recently [1] which makes us call
> for_each_available_child_of_node() on a potentially NULL node
> argument.

And yet in your reply to that patch you argued that the NULL check
should be in the caller!

Anyway, this isn't a big deal. Post a patch fixing both and I'll apply
it.

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/