linux-kernel - Re: [PATCH 1/6] Staging: rtl8192u: r8180_93cx6.c & r8192U_wx.c fix checkpatch.pl errors and warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140527203956.GO15585@mwanda>
Date:	Tue, 27 May 2014 23:39:56 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Chaitanya Hazarey <c@...io>
Cc:	gregkh@...uxfoundation.org, andrea.merello@...il.com,
	linville@...driver.com, burzalodowa@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/6] Staging: rtl8192u: r8180_93cx6.c & r8192U_wx.c fix
 checkpatch.pl errors and warnings

On Tue, May 27, 2014 at 01:09:45PM -0700, Chaitanya Hazarey wrote:
> Fixed the following:
> 
> ERROR: do not use C99 // comments
> ERROR: space required after that ',' (ctx:VxV)
> ERROR: space required after that ';' (ctx:VxV)
> ERROR: space required before the open brace '{'
> ERROR: spaces required around that '=' (ctx:VxV)
> ERROR: spaces required around that '<' (ctx:VxV)
> ERROR: space required after that close brace '}'
> ERROR: spaces required around that '==' (ctx:VxV)
> ERROR: space required before the open parenthesis '('
> 

All of these patches have the same subject.  And also they aren't
broken up in the correct way.  Basically for this kind of thing we want
to see one kind of cleanup per patch.

[patch 1/6] Staging: rtl8192u: add missing spaces
[patch 2/6] Staging: rtl8192u: delete commented out code
[patch 3/6] Staging: rtl8192u: clean up c99 comments
[patch 4/6] Staging: rtl8192u: reformat long lines
...

Etc.

Sorry for asking people to redo these again...

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/