linux-kernel - [PATCH] x86: intel-mid: fix watchdog platform code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 27 May 2014 14:21:10 -0700
From:	David Cohen <david.a.cohen@...ux.intel.com>
To:	wim@...ana.be, tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
	x86@...nel.org
Cc:	linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org,
	gnomes@...rguk.ukuu.org.uk,
	David Cohen <david.a.cohen@...ux.intel.com>
Subject: [PATCH] x86: intel-mid: fix watchdog platform code

This patch fixes missing include asm/io_apic.h which may lead to
following error:

   arch/x86/platform/intel-mid/device_libs/platform_wdt.c: In function 'tangier_probe':
>> arch/x86/platform/intel-mid/device_libs/platform_wdt.c:37:2: error: implicit declaration of function 'mp_find_ioapic' [-Werror=implicit-function-declaration]
     ioapic = mp_find_ioapic(irq);
     ^
>> arch/x86/platform/intel-mid/device_libs/platform_wdt.c:44:3: error: implicit declaration of function 'io_apic_set_pci_routing' [-Werror=implicit-function-declaration]
      ret = io_apic_set_pci_routing(NULL, irq, &irq_attr);
      ^
Signed-off-by: David Cohen <david.a.cohen@...ux.intel.com>
Reported-by: kbuild test robot <fengguang.wu@...el.com>
---

Hi,

Delta from v1 to v1.1: amend my e-mail from @intel.com to @linux.intel.com

FWIW it is not required to make INTEL_MID_WATCHDOG to depend on X86_IO_APIC,
because this driver already depends on X86_INTEL_MID (which depends on
X86_IO_APIC).

BR, David
---

 arch/x86/platform/intel-mid/device_libs/platform_wdt.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/platform/intel-mid/device_libs/platform_wdt.c b/arch/x86/platform/intel-mid/device_libs/platform_wdt.c
index a05315eb052d..973cf3bfa9fd 100644
--- a/arch/x86/platform/intel-mid/device_libs/platform_wdt.c
+++ b/arch/x86/platform/intel-mid/device_libs/platform_wdt.c
@@ -15,6 +15,7 @@
 #include <linux/platform_device.h>
 #include <linux/platform_data/intel-mid_wdt.h>
 #include <asm/intel-mid.h>
+#include <asm/io_apic.h>
 
 #define TANGIER_EXT_TIMER0_MSI 15
 
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/