linux-kernel - [RFC] Bluetooth: Keep master role when SCO or eSCO is active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1401256588-1467-1-git-send-email-kiran.kumar@linaro.org>
Date:	Wed, 28 May 2014 11:26:28 +0530
From:	Kiran Kumar Raparthy <kiran.kumar@...aro.org>
To:	linux-kernel@...r.kernel.org
Cc:	"hyungseoung.yoo" <hyungseoung.yoo@...sung.com>,
	Marcel Holtmann <marcel@...tmann.org>,
	Gustavo Padovan <gustavo@...ovan.org>,
	Johan Hedberg <johan.hedberg@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	linux-bluetooth@...r.kernel.org (open list:BLUETOOTH SUBSYSTEM),
	netdev@...r.kernel.org (open list:NETWORKING [GENERAL]),
	Android Kernel Team <kernel-team@...roid.com>,
	John Stultz <john.stultz@...aro.org>,
	Jaikumar Ganesh <jaikumarg@...roid.com>,
	Kiran Raparthy <kiran.kumar@...aro.org>
Subject: [RFC] Bluetooth: Keep master role when SCO or eSCO is active

From: "hyungseoung.yoo" <hyungseoung.yoo@...sung.com>

Preserve the master role when SCO or eSCO is active
as this improves compatability with lots of
headset and chipset combinations.

This is one of the number of patches from the Android AOSP
common.git tree, which is used on almost all Android devices.
It looks like it would improve support for compatibility with
lot of headset,so I wanted to submit it for review to see
if it should go upstream.

Cc: Marcel Holtmann <marcel@...tmann.org> (maintainer:BLUETOOTH SUBSYSTEM)
Cc: Gustavo Padovan <gustavo@...ovan.org> (maintainer:BLUETOOTH SUBSYSTEM)
Cc: Johan Hedberg <johan.hedberg@...il.com> (maintainer:BLUETOOTH SUBSYSTEM)
Cc: "David S. Miller" <davem@...emloft.net> (maintainer:NETWORKING [GENERAL])
Cc: linux-bluetooth@...r.kernel.org (open list:BLUETOOTH SUBSYSTEM)
Cc: netdev@...r.kernel.org (open list:NETWORKING [GENERAL])
Cc: linux-kernel@...r.kernel.org (open list)
Cc: Android Kernel Team <kernel-team@...roid.com>
Cc: John Stultz <john.stultz@...aro.org>
Signed-off-by: hyungseoung.yoo <hyungseoung.yoo@...sung.com>
Signed-off-by: Jaikumar Ganesh <jaikumarg@...roid.com>
[kiran: Added context to commit message]
Signed-off-by: Kiran Raparthy <kiran.kumar@...aro.org>
---
 net/bluetooth/hci_event.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
index 15010a2..6f944d5 100644
--- a/net/bluetooth/hci_event.c
+++ b/net/bluetooth/hci_event.c
@@ -1915,6 +1915,15 @@ unlock:
 	hci_conn_check_pending(hdev);
 }
 
+static inline bool is_sco_active(struct hci_dev *hdev)
+{
+	if (hci_conn_hash_lookup_state(hdev, SCO_LINK, BT_CONNECTED) ||
+			(hci_conn_hash_lookup_state(hdev, ESCO_LINK,
+						    BT_CONNECTED)))
+		return true;
+	return false;
+}
+
 static void hci_conn_request_evt(struct hci_dev *hdev, struct sk_buff *skb)
 {
 	struct hci_ev_conn_request *ev = (void *) skb->data;
@@ -1961,7 +1970,8 @@ static void hci_conn_request_evt(struct hci_dev *hdev, struct sk_buff *skb)
 
 			bacpy(&cp.bdaddr, &ev->bdaddr);
 
-			if (lmp_rswitch_capable(hdev) && (mask & HCI_LM_MASTER))
+			if (lmp_rswitch_capable(hdev) && ((mask & HCI_LM_MASTER)
+						|| is_sco_active(hdev)))
 				cp.role = 0x00; /* Become master */
 			else
 				cp.role = 0x01; /* Remain slave */
-- 
1.8.2.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/