linux-kernel - Re: [PATCH] Staging: speakup: don't die if accessing sysfs without synth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140528064901.GW6800@type.youpi.perso.aquilenet.fr>
Date:	Wed, 28 May 2014 08:49:01 +0200
From:	Samuel Thibault <samuel.thibault@...-lyon.org>
To:	Sasha Levin <sasha.levin@...cle.com>
Cc:	w.d.hubbs@...il.com, chris@...-brannons.com, kirk@...sers.ca,
	gregkh@...uxfoundation.org, speakup@...ille.uwo.ca,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: speakup: don't die if accessing sysfs without
 synth

Sasha Levin, le Tue 27 May 2014 19:08:36 -0400, a écrit :
> Setting a 'silent' parameter without a synth would crash the kernel.
> 
> Signed-off-by: Sasha Levin <sasha.levin@...cle.com>

Acked-by: Samuel Thibault <samuel.thibault@...-lyon.org>

> ---
>  drivers/staging/speakup/synth.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c
> index 0b3549b..172cf62 100644
> --- a/drivers/staging/speakup/synth.c
> +++ b/drivers/staging/speakup/synth.c
> @@ -212,6 +212,9 @@ void synth_start(void)
>  
>  void spk_do_flush(void)
>  {
> +	if (!synth)
> +		return;
> +
>  	speakup_info.flushing = 1;
>  	synth_buffer_clear();
>  	if (synth->alive) {
> -- 
> 1.7.10.4
> 

-- 
Samuel
Now I know someone out there is going to claim, "Well then, UNIX is intuitive,
because you only need to learn 5000 commands, and then everything else follows
from that! Har har har!"
(Andy Bates in comp.os.linux.misc, on "intuitive interfaces", slightly
defending Macs.)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/