linux-kernel - Re: [PATCH 1/1] ARM: ux500: Staticize ux500_soc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140528083649.GB10803@lee--X1>
Date:	Wed, 28 May 2014 09:36:49 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Sachin Kamat <sachin.kamat@...aro.org>
Cc:	linux-arm-kernel@...ts.infradead.org, linus.walleij@...aro.org,
	linux@....linux.org.uk, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] ARM: ux500: Staticize ux500_soc_attr

On Wed, 28 May 2014, Sachin Kamat wrote:

> 'ux500_soc_attr' is local to this file. While at it also make it
> const to match the argument list of device_create_file.

What's going on Sachin?  I Acked v2 of this patch an hour ago, yet
you've resent it as a v1 and without the Ack?

> Signed-off-by: Sachin Kamat <sachin.kamat@...aro.org>
> ---
>  arch/arm/mach-ux500/cpu.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-ux500/cpu.c b/arch/arm/mach-ux500/cpu.c
> index db16b5a04ad5..dbb2970ee7da 100644
> --- a/arch/arm/mach-ux500/cpu.c
> +++ b/arch/arm/mach-ux500/cpu.c
> @@ -125,7 +125,7 @@ static void __init soc_info_populate(struct soc_device_attribute *soc_dev_attr,
>  	soc_dev_attr->revision = ux500_get_revision();
>  }
>  
> -struct device_attribute ux500_soc_attr =
> +static const struct device_attribute ux500_soc_attr =
>  	__ATTR(process,  S_IRUGO, ux500_get_process,  NULL);
>  
>  struct device * __init ux500_soc_device_init(const char *soc_id)

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/