linux-kernel - Re: [PATCH] pwm: i.MX: Cleanup indentation for register definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140528115636.4ad791aa@ipc1.ka-ro>
Date:	Wed, 28 May 2014 11:56:36 +0200
From:	Lothar Waßmann <LW@...O-electronics.de>
To:	Liu Ying <Ying.Liu@...escale.com>
Cc:	<linux-pwm@...r.kernel.org>, <thierry.reding@...il.com>,
	<s.hauer@...gutronix.de>, <shawn.guo@...escale.com>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pwm: i.MX: Cleanup indentation for register definitions

Hi,

Liu Ying wrote:
> This patch contains no logic change to cleanup indentation
> for register definitions only.
> 
> Cc: Thierry Reding <thierry.reding@...il.com>
> Cc: Sascha Hauer <s.hauer@...gutronix.de>
> Cc: Shawn Guo <shawn.guo@...escale.com>
> Cc: Lothar Waßmann <LW@...O-electronics.de>
> Cc: linux-pwm@...r.kernel.org
> Cc: linux-arm-kernel@...ts.infradead.org
> Signed-off-by: Liu Ying <Ying.Liu@...escale.com>
> ---
>  drivers/pwm/pwm-imx.c |   26 +++++++++++++-------------
>  1 file changed, 13 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c
> index cc47733..0784554 100644
> --- a/drivers/pwm/pwm-imx.c
> +++ b/drivers/pwm/pwm-imx.c
> @@ -21,24 +21,24 @@
>  
>  /* i.MX1 and i.MX21 share the same PWM function block: */
>  
> -#define MX1_PWMC    0x00   /* PWM Control Register */
> -#define MX1_PWMS    0x04   /* PWM Sample Register */
> -#define MX1_PWMP    0x08   /* PWM Period Register */
> +#define MX1_PWMC			0x00   /* PWM Control Register */
> +#define MX1_PWMS			0x04   /* PWM Sample Register */
> +#define MX1_PWMP			0x08   /* PWM Period Register */
>  
> -#define MX1_PWMC_EN		(1 << 4)
> +#define MX1_PWMC_EN			(1 << 4)
>  
>  /* i.MX27, i.MX31, i.MX35 share the same PWM function block: */
>  
> -#define MX3_PWMCR                 0x00    /* PWM Control Register */
> -#define MX3_PWMSAR                0x0C    /* PWM Sample Register */
> -#define MX3_PWMPR                 0x10    /* PWM Period Register */
> -#define MX3_PWMCR_PRESCALER(x)    (((x - 1) & 0xFFF) << 4)
> -#define MX3_PWMCR_DOZEEN                (1 << 24)
> -#define MX3_PWMCR_WAITEN                (1 << 23)
> +#define MX3_PWMCR			0x00    /* PWM Control Register */
> +#define MX3_PWMSAR			0x0C    /* PWM Sample Register */
> +#define MX3_PWMPR			0x10    /* PWM Period Register */
> +#define MX3_PWMCR_PRESCALER(x)		(((x - 1) & 0xFFF) << 4)
                                                   ^
You could also add the missing () around the macro argument when you
are changing this line anyway.


Lothar Waßmann
-- 
___________________________________________________________

Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | info@...o-electronics.de
___________________________________________________________
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/