linux-kernel - Re: [PATCH 7/9] tlan: Make autonegotiation faster

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5385EE7A.2030501@cogentembedded.com>
Date:	Wed, 28 May 2014 18:11:06 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Ondrej Zary <linux@...nbow-software.org>,
	Samuel Chessman <chessman@....org>
CC:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 7/9] tlan: Make autonegotiation faster

Hello.

On 05/28/2014 01:38 AM, Ondrej Zary wrote:

> Reduce the autonegotiation poll interval from 8 seconds to 2.
> This greatly reduces the time needed to detect link presence,
> especially on Olicom cards at 10 Mbps (two autonegoatiations required).

> Signed-off-by: Ondrej Zary <linux@...nbow-software.org>
> ---
>   drivers/net/ethernet/ti/tlan.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/drivers/net/ethernet/ti/tlan.c b/drivers/net/ethernet/ti/tlan.c
> index 628a779..007c2fe 100644
> --- a/drivers/net/ethernet/ti/tlan.c
> +++ b/drivers/net/ethernet/ti/tlan.c
> @@ -2699,7 +2699,7 @@ static void tlan_phy_finish_auto_neg(struct net_device *dev)
>   		/* Wait for 8 sec to give the process
>   		 * more time.  Perhaps we should fail after a while.
>   		 */
> -		tlan_set_timer(dev, (8*HZ), TLAN_TIMER_PHY_FINISH_AN);
> +		tlan_set_timer(dev, (2*HZ), TLAN_TIMER_PHY_FINISH_AN);

    The inner () not needed but space around * wouldn't hurt.

>   		return;
>   	}

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/