linux-kernel - Re: [PATCH] scsi/NCR5380: dprintk macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140528155336.GB14981@infradead.org>
Date:	Wed, 28 May 2014 08:53:36 -0700
From:	Christoph Hellwig <hch@...radead.org>
To:	Finn Thain <fthain@...egraphics.com.au>
Cc:	Christoph Hellwig <hch@...radead.org>,
	"James E.J. Bottomley" <JBottomley@...allels.com>,
	linux-scsi@...r.kernel.org, Sam Creasey <sammy@...my.net>,
	Russell King <linux@....linux.org.uk>,
	Michael Schmitz <schmitz@...ian.org>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-m68k@...r.kernel.org
Subject: Re: [PATCH] scsi/NCR5380: dprintk macro

On Thu, May 29, 2014 at 12:43:43AM +1000, Finn Thain wrote:
> 
> This is the delta between the two submissions:
> [PATCH 00/12] scsi/NCR5380: fix debugging macros and #include structure
> and
> [PATCH v2 00/12] scsi/NCR5380: fix debugging macros and #include structure
> 
> The macro definition changes were discussed on the mailing list during 
> review. The idea is to get the compiler to check the parameters of 
> disabled printk() calls so that the debugging code doesn't rot again.
> 
> Signed-off-by: Finn Thain <fthain@...egraphics.com.au>

Thanks a lot Finn!

> I know the whitespace is wrong throughout these drivers but when I put 
> this patch series together it seemed best to defer the whitespace cleanup. 
>(I still intend to do that cleanup.)

Yes, I ignored the whitespace warnings in the debug macro cleanups.  I
fixed them up for the "newly" added code in the sun3 driver merge.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/