linux-kernel - Re: [PATCH] block: mq flush: fix race between IPI handler and mq flush worker

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53854A76.1050807@kernel.dk>
Date:	Tue, 27 May 2014 20:31:18 -0600
From:	Jens Axboe <axboe@...nel.dk>
To:	Ming Lei <tom.leiming@...il.com>
CC:	Christoph Hellwig <hch@....de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	stable <stable@...r.kernel.org>
Subject: Re: [PATCH] block: mq flush: fix race between IPI handler and mq
 flush worker

On 2014-05-27 20:26, Jens Axboe wrote:
> On 2014-05-27 19:34, Ming Lei wrote:
>> On Wed, May 28, 2014 at 3:35 AM, Jens Axboe <axboe@...nel.dk> wrote:
>>> On 05/27/2014 01:21 PM, Christoph Hellwig wrote:
>>>> On Tue, May 27, 2014 at 01:17:40PM -0600, Jens Axboe wrote:
>>>>> But I think you sent the old one again, not the new variant :-)
>>>>
>>>> Oh well, next try:
>>>
>>> This looks good to me. Was trying to think of ways to reduce that to one
>>> list iteration, but I think it's cleaner to just retain the two separate
>>> ones.
>>>
>>> Reusing REQ_SOFTBARRIER is fine as well, not used in blk-mq otherwise.
>>>
>>> Let me know when you have runtime verified it.
>>
>> Looks writing over ext4(especially sync writing) can survive
>> with Christoph's patch now, thanks Christoph.
>>
>> Reported-and-tested-by: Ming Lei <tom.leiming@...il.com>
>
> Great! I'll queue it up here too, then.

Christoph, I'll just run a few tests and then queue it up in the 
morning. Can you send a properly signed-off patch with a commit message 
as well? I was writing one up, but I still need the signed-off-by.


-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/