linux-kernel - Re: [PATCH v3] pinctrl: to avoid duplicated calling enable_pinmux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53878829.4050703@wwwdotorg.org>
Date:	Thu, 29 May 2014 13:19:05 -0600
From:	Stephen Warren <swarren@...dotorg.org>
To:	fwu@...vell.com, linus.walleij@...aro.org, tony@...mide.com
CC:	linux-kernel@...r.kernel.org, swarren@...dia.com,
	cxie4@...vell.com, ylmao@...vell.com, njiang1@...vell.com,
	tianxf@...vell.com, fswu@...vell.com
Subject: Re: [PATCH v3] pinctrl: to avoid duplicated calling enable_pinmux_setting
 for a pin

On 05/25/2014 08:43 PM, fwu@...vell.com wrote:
> From: Fan Wu <fwu@...vell.com>
> 
> What the patch did:
> 1.To call pinmux_disable_setting ahead of pinmux_enable_setting in each time of
>   calling pinctrl_select_state
> 2.Remove the HW disable operation in in pinmux_disable_setting function.
...

This commit description is way too long for such a simple change. A much
shorter summary would be better.

> Signed-off-by: Fan Wu <fwu@...vell.com>
> Signed-off-by: Stephen Warren <swarren@...dia.com>

I'm pretty sure I never signed off on this patch. How come my s-o-b line
is there?

This patch still doesn't remove ops->disable from the struct pinmux_ops,
nor any of its implementations. Shouldn't it?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/