linux-kernel - Re: [PATCH] fs: ocfs2: move_extents.c: Fix to remove null pointer checks that could never happen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140529154250.4be24a07ec68eb2eef41e8e2@linux-foundation.org>
Date:	Thu, 29 May 2014 15:42:50 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc:	Dave Jones <davej@...hat.com>, Mark Fasheh <mfasheh@...e.com>,
	Joel Becker <jlbec@...lplan.org>, ocfs2-devel@....oracle.com,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Jeff Liu <jeff.liu@...cle.com>
Subject: Re: [PATCH] fs: ocfs2: move_extents.c: Fix to remove null pointer
 checks that could never happen

On Fri, 30 May 2014 00:39:24 +0200 Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> wrote:

> Hi all!
> 
> First, I'm no expert on this code, but after a patch which I thought
> was most accurate for the current code was written before, which was
> rather something like the code below.
> Then Jeff Liu that this was not something that could happen. So I send
> a patch where the check was removed instead.
> And that's where we are now. :-)
> 

Well if Jeff says that inode==NULL cannot happen then that is the info
I was after, and the original patch is OK.  Please resend, with that
important info in the changelog ;)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/