linux-kernel - Re: [PATCH] gpio: gpiolib: set gpiochip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140530085832.711df1c6@canb.auug.org.au>
Date:	Fri, 30 May 2014 08:58:32 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	abdoulaye berthe <berthe.ab@...il.com>
Cc:	linus.walleij@...aro.org, gnurou@...il.com,
	mika.westerberg@...ux.intel.com, andriy.shevchenko@...ux.intel.com,
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpio: gpiolib: set gpiochip_remove retval to void

Hi abdoulaye,

On Fri, 30 May 2014 00:32:02 +0200 abdoulaye berthe <berthe.ab@...il.com> wrote:
>
> +		if (test_bit(FLAG_REQUESTED, &chip->desc[id].flags))
> +			panic("gpio: removing gpiochip with gpios still requested\n");

Someone else already commented that panic is probably overkill ... is
there no way to log this and continue?

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)