linux-kernel - Re: [RFC PATCH v2 1/1] rename {before/after}_atomic_{inc/dec} to {before/after}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5386BB13.1070908@gmail.com>
Date:	Thu, 29 May 2014 00:44:03 -0400
From:	Pranith Kumar <bobby.prani@...il.com>
To:	peterz@...radead.org, paulmck@...ux.vnet.ibm.com
CC:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH v2 1/1] rename {before/after}_atomic_{inc/dec} to
 {before/after}_atomic

On 05/29/2014 12:28 AM, Pranith Kumar wrote:

> diff --git a/kernel/sched/cpupri.c b/kernel/sched/cpupri.c
> index 3031bac..a5635ad 100644
> --- a/kernel/sched/cpupri.c
> +++ b/kernel/sched/cpupri.c
> @@ -164,7 +164,7 @@ void cpupri_set(struct cpupri *cp, int cpu, int newpri)
>  		 * do a write memory barrier, and then update the count, to
>  		 * make sure the vector is visible when count is set.
>  		 */
> -		smp_mb__before_atomic_inc();
> +		smp_mb__before_atomic();
>  		atomic_inc(&(vec)->count);
>  		do_mb = 1;
>  	}
> @@ -184,14 +184,14 @@ void cpupri_set(struct cpupri *cp, int cpu, int newpri)
>  		 * the new priority vec.
>  		 */
>  		if (do_mb)
> -			smp_mb__after_atomic_inc();
> +			smp_mb__after_atomic();
>  
>  		/*
>  		 * When removing from the vector, we decrement the counter first
>  		 * do a memory barrier and then clear the mask.
>  		 */
>  		atomic_dec(&(vec)->count);
> -		smp_mb__after_atomic_inc();
> +		smp_mb__after_atomic();
>  		cpumask_clear_cpu(cpu, vec->mask);
>  	}
>  

We should at the least fix this :)



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/