linux-kernel - Re: [PATCH net-next v1] mrf24j40: add managed API's provided by device layer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEUmHybO0GHykgLAn9Gm5RZEJNdopzFxR_inniE50V5SQiSeOA@mail.gmail.com>
Date:	Thu, 29 May 2014 12:42:37 +0530
From:	Varka Bhadram <varkabhadram@...il.com>
To:	Tushar Behera <trblinux@...il.com>
Cc:	Alan Ott <alan@...nal11.us>,
	Alexander Smirnov <alex.bluesman.smirnov@...il.com>,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	linux-zigbee-devel@...ts.sourceforge.net, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, davem@...emloft.net,
	Alexandra Serrano <alex.aing@...il.com>,
	Varka Bhadram <varkab@...c.in>
Subject: Re: [PATCH net-next v1] mrf24j40: add managed API's provided by
 device layer

Thanks for the suggestions.

I send the v2 patch which uses devm_kzalloc().

Regards,
Varka Bhadram

On Thu, May 29, 2014 at 12:02 PM, Tushar Behera <trblinux@...il.com> wrote:
> On Thu, May 29, 2014 at 10:10:21AM +0530, Varka Bhadram wrote:
>> Hi,
>>       Previous patch having bug in using managed API's. I fixed that.
>>
>> Regards,
>> Varka Bhadram.
>
> Only add relevant commit message here, no need to add 'Hi' and
> 'Regards'.
>
> Something like ...
>
> "Added devres managed APIs"
>
>>
>> Signed-off-by: Varka Bhadram <varkab@...c.in>
>> ---
>>  drivers/net/ieee802154/mrf24j40.c |   21 +++++++++------------
>>  1 file changed, 9 insertions(+), 12 deletions(-)
>>
>> diff --git a/drivers/net/ieee802154/mrf24j40.c b/drivers/net/ieee802154/mrf24j40.c
>> index 78a6552..f701cdb 100644
>> --- a/drivers/net/ieee802154/mrf24j40.c
>> +++ b/drivers/net/ieee802154/mrf24j40.c
>> @@ -618,10 +618,10 @@ static int mrf24j40_probe(struct spi_device *spi)
>>
>>       printk(KERN_INFO "mrf24j40: probe(). IRQ: %d\n", spi->irq);
>>
>> -     devrec = kzalloc(sizeof(struct mrf24j40), GFP_KERNEL);
>> +     devrec = devm_kzalloc(&spi->dev, sizeof(struct mrf24j40), GFP_KERNEL);
>>       if (!devrec)
>>               goto err_devrec;
>> -     devrec->buf = kzalloc(3, GFP_KERNEL);
>> +     devrec->buf = kzalloc(&spi->dev, 3, GFP_KERNEL);
>
> devm_kzalloc()
>
> Without this, it should not build at all. So remember to compile test
> before sending the patches.
>
> --
> Warm regards,
> Tushar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/