linux-kernel - Re: xfs: possible deadlock warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140529074909.GI6677@dastard>
Date:	Thu, 29 May 2014 17:49:09 +1000
From:	Dave Chinner <david@...morbit.com>
To:	Gu Zheng <guz.fnst@...fujitsu.com>
Cc:	xfs@....sgi.com, linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: xfs: possible deadlock warning

On Thu, May 29, 2014 at 11:34:21AM +0800, Gu Zheng wrote:
> Hi Dave,
> 
> On 05/28/2014 02:00 PM, Dave Chinner wrote:
> 
> > On Wed, May 28, 2014 at 01:19:16PM +0800, Gu Zheng wrote:
> >> Hi all,
> >> When running the latest Linus' tree, the following possible deadlock warning occurs.
> > 
> > false positive. There isn't a deadlock between inode locks on
> > different filesystems. i.e. there is no dependency between shmem
> > inodes and xfs inodes, nor on their security contexts.  Nor can you
> > take a page fault on a directory inode, which is the XFS inode lock
> > class it's complaining about.
> 
> If it's really a noisy, can we avoid this?

It's on my list of things to do. The XFs directory locking was
changed slightly to remove race condition that SGI's CXFS filesystem
was hitting, and that introduced all these lockdep false positives.

Unfortunately, to get rid of the lockdep false positives we can
either:

	a) revert the locking change; or
	b) rewrite the readdir code to use more fine grained locking
	   so that we don't hold the lock over filldir() calls.

I don't think that reverting a change that fixed a directory
corruption problem is a good idea, so rewriting the readdir code is
the solution.

SGI have disappeared off the planet so they aren't going to fix it
anytime soon, so it's waiting for me to find the time to finish and
test the patches I have ibeen working on in my spare time that
rework the readdir code.

Cheers,

Dave.
-- 
Dave Chinner
david@...morbit.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/